Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use node:fs instead of fs-extra #4104

Merged
merged 1 commit into from Mar 12, 2023
Merged

Conversation

targos
Copy link
Member

@targos targos commented Mar 12, 2023

No description provided.

@thetutlage
Copy link
Member

Any reasons we are using existsSync method?

@targos
Copy link
Member Author

targos commented Mar 12, 2023

Simpler ( there is no exists method in fs promises ) and not a problem to make sync calls at this location

@thetutlage
Copy link
Member

thetutlage commented Mar 12, 2023

Okay, I wasn't aware that there is no async exists method

@thetutlage thetutlage merged commit 2334b13 into adonisjs:next Mar 12, 2023
4 checks passed
@targos targos deleted the fs-extra branch March 12, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants