Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routing): allow to prefix a group without a starting slash #416

Merged
merged 2 commits into from
Jan 12, 2017
Merged

fix(routing): allow to prefix a group without a starting slash #416

merged 2 commits into from
Jan 12, 2017

Conversation

RomainLanz
Copy link
Member

We should be able to prefix route's group without writing the first
slash.

Example:

Route.group('v1', function () {
  // Some routes...
}).prefix('api/v1') // before it should be .prefix('/api/v1')

Closes: #415

We should be able to prefix route's group without writing the first
slash.

Example:
```javascript
Route.group('v1', function () {
  // Some routes...
}).prefix('api/v1') // before it should be .prefix('/api/v1')
```

Closes: #415
@coveralls
Copy link

coveralls commented Jan 6, 2017

Coverage Status

Coverage increased (+0.001%) to 98.185% when pulling d35effe on RomainLanz:fix/route-group-prefix into c0fc707 on adonisjs:develop.

@thetutlage thetutlage merged commit 391b149 into adonisjs:develop Jan 12, 2017
@thetutlage
Copy link
Member

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route Group prefix not working without leading slash
3 participants