New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an node ace add
command
#4296
Conversation
I don't think we should consider this feedback. If someone's comments seem illogical or uninformed, it's not our responsibility. Adding a |
I also think that people are now more used to this kind of CLI commands. Some popular framework has adopted the same. for example Astro : https://docs.astro.build/en/guides/integrations-guide/#automatic-integration-setup. Vue CLI ( now deprecated ), Expo, Redwood also have something like that |
Cool. How do we accept and pass other CLI args to the spawned process? |
Are you talking about the arguments to be passed on to the package manager?
I'll add the |
Should be ready to merge
|
Looks good to me. We will need some documentation for it and maybe a blog post too, explaining why we added this command and some quick examples. |
Yes, I believe it makes sense, and we made this command to avoid people having to do two commands. |
Send a draft PR for the documentation : Let's merge in the meantime |
This PR adds the
node ace add {packageName}
command to the core, allowing users to install and configure a package in a single command.With V5, we often had feedback from people complaining that X or Y package wasn't working, because they'd forgotten to type
node ace configure
after installing their package.This command would avoid this. can be used like :
each unknown argument will be passed to the configure command. So we can do something like this :
if this is a dev dependency we can use the
-D
flagI've also handled the two special cases, edge and vine, which can be installed like this: