Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update knex #421

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Update knex #421

merged 2 commits into from
Feb 6, 2019

Conversation

caiquecastro
Copy link
Contributor

Change to the latest version

Proposed changes

The latest knex version contains new features and bug fixes like: knex changelog

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

The breaking changes are: https://github.com/tgriesser/knex/blob/master/CHANGELOG.md#breaking-changes

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Change to the latest version
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.499% when pulling 46e3de7 on caiquecastro:patch-1 into 7ed4138 on adonisjs:develop.

@coveralls
Copy link

coveralls commented Feb 5, 2019

Coverage Status

Coverage remained the same at 96.499% when pulling 76eb03b on caiquecastro:patch-1 into 7ed4138 on adonisjs:develop.

On the newer knex version, the increment method binds its argument on query
@caiquecastro
Copy link
Contributor Author

The probably reason why the tests changed: knex/knex@66acbe7#diff-2ee33e306d47d27f6349fbefe16e28e0

@RomainLanz RomainLanz merged commit fe5fa00 into adonisjs:develop Feb 6, 2019
@RomainLanz
Copy link
Member

Thanks! 💜

@caiquecastro caiquecastro deleted the patch-1 branch February 6, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants