Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select table before truncating #55

Merged
merged 2 commits into from Oct 11, 2016

Conversation

marines
Copy link
Contributor

@marines marines commented Oct 3, 2016

No description provided.

@coveralls
Copy link

coveralls commented Oct 3, 2016

Coverage Status

Coverage remained the same at 97.073% when pulling 56e149e on marines:db-table-seeding-fix into 073daa7 on adonisjs:develop.

@thetutlage
Copy link
Member

Thanks for the change. Can you please also make another change?

https://github.com/marines/adonis-lucid/blob/56e149e2f838d2b79d309460f53be26963186639/src/Factory/DatabaseFactory.js#L84
needs to be updated. I am mistakenly overriding the database instance which is not right.

The line needs to create a local variable and then re-use it.

const binding = this.binding.table(this.dbTable)

and then re-using the new local var here https://github.com/marines/adonis-lucid/blob/56e149e2f838d2b79d309460f53be26963186639/src/Factory/DatabaseFactory.js#L88

@marines
Copy link
Contributor Author

marines commented Oct 3, 2016

Sure, will do.

@RomainLanz
Copy link
Member

Dear @marines,

When will you able to process the requested change?

Thanks for your contribution!

@marines
Copy link
Contributor Author

marines commented Oct 5, 2016

I'll do it on Friday morning (CET) when I come back from short holidays.

@coveralls
Copy link

coveralls commented Oct 8, 2016

Coverage Status

Coverage increased (+0.05%) to 97.126% when pulling 495eb88 on marines:db-table-seeding-fix into 073daa7 on adonisjs:develop.

@marines
Copy link
Contributor Author

marines commented Oct 9, 2016

@RomainLanz @thetutlage you can check if it's ok.

@thetutlage thetutlage merged commit 495eb88 into adonisjs:develop Oct 11, 2016
@marines marines deleted the db-table-seeding-fix branch October 11, 2016 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants