Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing await #26

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Added missing await #26

merged 1 commit into from
Feb 6, 2019

Conversation

grachov
Copy link
Contributor

@grachov grachov commented Dec 9, 2018

removeToken should be called with await (as in updatePasswordByToken) and also it's better to call it when user was updated.

@coveralls
Copy link

coveralls commented Dec 9, 2018 •
edited

Pull Request Test Coverage Report for Build 44

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.514%
Totals Coverage Status
Change from base Build 42: 0.0%
Covered Lines: 136
Relevant Lines: 141
💛 - Coveralls

@willvincent willvincent mentioned this pull request Feb 4, 2019
Closed
@RomainLanz RomainLanz merged commit 5104e11 into adonisjs:develop Feb 6, 2019
@RomainLanz
Copy link
Member

Thanks! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grachov @coveralls @RomainLanz