refactor: remove X-Download-Options header support

adonisjs · Mar 23, 2021 · d691d4a · d691d4a
1 parent 9e5884d
commit d691d4a
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 93 deletions.
diff --git a/adonis-typings/shield.ts b/adonis-typings/shield.ts
@@ -43,13 +43,6 @@ declare module '@ioc:Adonis/Addons/Shield' {
     preload?: boolean
   }
 
-  /**
-   * Config for X-Download-Options
-   */
-  export type IENoOpenOptions = {
-    enabled: boolean
-  }
-
   /**
    * Config for X-DNS-Prefetch-Control
    */
@@ -81,7 +74,6 @@ declare module '@ioc:Adonis/Addons/Shield' {
     xFrame: XFrameOptions
     contentTypeSniffing: ContentTypeSniffingOptions
     hsts: HstsOptions
-    noOpen: IENoOpenOptions
     dnsPrefetch: DnsPrefetchOptions
     csp: CspOptions
     csrf: CsrfOptions

diff --git a/src/ShieldMiddleware/index.ts b/src/ShieldMiddleware/index.ts
@@ -28,7 +28,6 @@ export class ShieldMiddleware {
     shield.dnsPrefetchFactory(this.config.dnsPrefetch || {}),
     shield.frameGuardFactory(this.config.xFrame || {}),
     shield.hstsFactory(this.config.hsts || {}),
-    shield.noOpenFactory(this.config.noOpen || {}),
     shield.noSniffFactory(this.config.contentTypeSniffing || {}),
   ]
 

diff --git a/src/noOpen.ts b/src/noOpen.ts
diff --git a/standalone.ts b/standalone.ts
@@ -10,7 +10,6 @@
 export { cspFactory } from './src/csp'
 export { csrfFactory } from './src/csrf'
 export { hstsFactory } from './src/hsts'
-export { noOpenFactory } from './src/noOpen'
 export { noSniffFactory } from './src/noSniff'
 export { frameGuardFactory } from './src/frameGuard'
 export { dnsPrefetchFactory } from './src/dnsPrefetch'
diff --git a/templates/shield.txt b/templates/shield.txt
@@ -122,23 +122,6 @@ export const csrf: ShieldConfig['csrf'] = {
   methods: ['POST', 'PUT', 'PATCH', 'DELETE'],
 }
 
-/*
-|--------------------------------------------------------------------------
-| No Open
-|--------------------------------------------------------------------------
-|
-| This will prevent old versions of Internet Explorer from allowing
-| malicious HTML downloads to be executed in the context of your
-| site.
-|
-| By default, the security header is disabled, since not many websites are
-| running on ie8 these days.
-|
-*/
-export const noOpen: ShieldConfig['noOpen'] = {
-  enabled: false,
-}
-
 /*
 |--------------------------------------------------------------------------
 | DNS Prefetching

diff --git a/test/no-open.spec.ts b/test/no-open.spec.ts