Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

chore: update dependencies #33

Merged
merged 2 commits into from
Mar 26, 2022
Merged

chore: update dependencies #33

merged 2 commits into from
Mar 26, 2022

Conversation

targos
Copy link
Member

@targos targos commented Mar 25, 2022

To cleanup before #32

@targos
Copy link
Member Author

targos commented Mar 25, 2022

Is it normal that npm test and GitHub actions don't catch TS errors? (npm run build fails with a lot of errors related to japa)

@targos
Copy link
Member Author

targos commented Mar 25, 2022

It seems that the TypeScript configuration doesn't include the .bin folder, which contains the import of @japa/assert, so the module augmentation doesn't happen.
Renaming the folder to 'bin' fixes it, but I'm not sure if it's expected that the name is .bin. Personally I don't like it because it is hidden in the terminal.

@thetutlage
Copy link
Member

thetutlage commented Mar 26, 2022

Using the .bin folder is a mistake. We have renamed it in many other places to bin.

Feel free to rename it in this PR itself :)

@targos targos requested a review from thetutlage March 26, 2022 11:25
@targos
Copy link
Member Author

targos commented Mar 26, 2022

Breaking change from mrm is:
image

@targos
Copy link
Member Author

targos commented Mar 26, 2022

I don't get how the new commit could break windows (it passed before)

@thetutlage
Copy link
Member

Re-ran the tests and all went fine :/

@thetutlage thetutlage merged commit 3a9be6d into adonisjs:develop Mar 26, 2022
@targos targos deleted the updeps branch March 26, 2022 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants