Using DatabaseTransactions does not play well with app transactions

[moltar]

Test:

trait('DatabaseTransactions')

test('...', async ({ assert }) => {
  // this is created inside a trx1 via DatabaseTransactions
  const user = await Factory
    .model('App/Models/User')
    .create()

  const res = await userFacade.doStuff(user, 'foo')
})

App code (App/Facades/userFacade.js):

  async doStuff (user, foo) {
    // will start a new trx2, which then does not see the user previously created outside of this txn
    const trx = await use('Database').beginTransaction()

    await user.stuff().create({}, trx)
  }

[RomainLanz]

Hey @moltar! 👋

This is a known issue that is going to be fixed.
In the meanwhile, I recommend you to change your code for the following.

const globalTrx = Database.connection('mysql')._globalTrx
const trx =  globalTrx ? globalTrx : await Database.beginTransaction()

// Do your stuff....
const article = await Article.create(metadata, trx)
await article.translations().create(translation, trx)

if (!globalTrx) {
  trx.commit()
}

[moltar]

What about savepoints? Knex supports that and could be an easy & quick fix.

[s0ld13r]

Are there any updates on this issue?

[thetutlage]

Nope not yet. However, if someone is interested in working on same. I can help in guiding them

[borie88]

This has been fixed in the latest Lucid release, right? @thetutlage

[viniciusoyama]

What if we create a trait for a DatabaseTruncate strategy?

[erikkallen]

Thnx for the workaround, I was wondering why transactions where not cleaning up the database after each test. This explains it.

[luisguilhermemsalmeida]

Hey guys! Do we have a solution to this problem?

[mateus4k]

@luisguilhermemsalmeida apparently no changes so far

[fnoquiq]

Has this been fixed? (for adonis v4.1)