-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncaught TypeError: ember_new_computed.default.readOnly is not a function #92
Comments
This "bug" was introduced in version |
This issue is holding my upgrade to ember 2.0. Have others been able to upgrade ember with the latest version of the addon? |
I also see this error when attempting to use ember-cli-flash 1.3.4 with Ember 1.13.9. Tested with the not-yet-released 1.3.5 and still got the same error. |
Thanks for the report and super sorry for not following up on this earlier. I'm looking into it, hopefully @rwjblue can also chime in |
@poteto - Do we have a reproduction? |
I'm personally unable to reproduce the issue on a fresh-generated app using Ember-CLI 1.13.8, so it may be some interaction with the other dependencies of my app (and @pedrokost's). I haven't had time yet to investigate further, but I can confirm that downgrading to 1.3.1 also resolves the issue for me. |
What is the output of |
@poteto - I suspect the issue is that some other addon is including ember-new-computed@1.0.0 that is overriding the version that you are using here. 1.0.0 did not provide Work around solution for that would be to use |
@rwjblue Thanks for the pointer! It appears I was using an older version of I'm not completely familiar with the workings of NPM, but shouldn't this kind of conflict raise an error at |
npm allows both to be installed, and the ember-cli build pipeline is geared towards preventing duplication in the build output. This leads to the "last" addon "winning" and clobbering other versions. |
If we didn't do this, then you would have many versions of various deps shipped in |
That... seems incredibly danger-prone. Given it's a situation where your app is almost guaranteed to be broken, shouldn't the build process at least warn you about it? (if not outright prevent you from building the app in such a state) |
Included: * ember-cli-moment upgrade now provides a service with `changeLocale` method * ember-cli-font-awesome now requires `icon` parameter to `fa-icon` component Not included: * modernizr (need to generate a custom build for v3) * ember-cli-flash (adopted-ember-addons/ember-cli-flash#92) * ember-simple-auth (need to overhaul for 1.0 Ember-CLI addon) * ember-cli-deploy (need to update deployment workflow for 0.5) * ember-i18n (need to rebase custom branch on latest official version) * ember-leaflet (need to update to official Ember-CLI addon release) * Ember 2.x (need to update ember-simple-auth and ember-leaflet first)
This also allows upgrading ember-cli-flash to the latest version: adopted-ember-addons/ember-cli-flash#92
Using ember-cli-flash@1.3.3
Ember : 1.13.6
Ember Data : 2.0.0-beta.1
jQuery : 2.1.4
in line 14 of
object.js
:The text was updated successfully, but these errors were encountered: