Slashed components rendering and ignore issue fix #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifeart
changed the title
|
@lifeart wow this looks like a TON of work! Thank you for pouring all the time into this from a test point of view! |
|
@lifeart bummer - this had a regression (published version v1.4.1) so I had to revert and publish v1.4.2 If you have time this week could you triage what broke w/ your changes here? I think this PR offers something of value but I didn't want to break the addon for users who are having good luck w/ v1.4 You can use this demo app to triage further (error was action related) |
|
@toranb sorry for regression, going to check what's going on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of #98
fix for #97
including test components