New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[slashed-components] regression fix #101

Closed

lifeart wants to merge 4 commits into adopted-ember-addons:master from lifeart:slashed-components

Contributor

lifeart commented Oct 9, 2018 •

edited

Loading

fix for #99

Main idea is - we need to return resolved value in template case only if (and):

this is slashed component
this is ignored component
this is not template-only component

lifeart added 4 commits

October 9, 2018 10:50


          regression fix

2b3e1dd


          codestyle cleanups

80214d0


          merge-conflicts

90c9e21


          removed redurant checks

2e8804e

Collaborator

toranb commented Oct 10, 2018

@lifeart ah great work! You mind squashing this down to a single commit before we merge it?

lifeart mentioned this pull request

[slashed-components] rebel #103

Open

lifeart closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet