Show warning for missing <meta> tag
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the ember-cli-storybook addon is used there is no meta tag since it is currently generating a different HTML file that does not contain it. While it is okay for ember-cli-ifa to not work correctly in those cases we shouldn't crash the app, but instead show a warning indicating that the addon might not work as expected. Since fingerprinting and ember-cli-ifa are usually only enabled in production builds and ember-cli-storybook is aimed more at development builds that seems like a reasonable tradeoff until ember-cli-storybook can fix how it builds the HTML file.
Turbo87
force-pushed
the
meta-missing
branch
from
e0512e4
to
89d76dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the ember-cli-storybook addon is used there is no meta tag since it is currently generating a different HTML file that does not contain it. While it is okay for ember-cli-ifa to not work correctly in those cases we shouldn't crash the app, but instead show a warning indicating that the addon might not work as expected. Since fingerprinting and ember-cli-ifa are usually only enabled in production builds and ember-cli-storybook is aimed more at development builds that seems like a reasonable tradeoff until ember-cli-storybook can fix how it builds the HTML file.
tl;dr this adds basic compatibility with ember-cli-storybook