Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning for missing <meta> tag #100

Merged
merged 1 commit into from
Nov 27, 2019

Commits on Nov 27, 2019

  1. Show warning for missing <meta> tag

    When the ember-cli-storybook addon is used there is no meta tag since it is currently generating a different HTML file that does not contain it. While it is okay for ember-cli-ifa to not work correctly in those cases we shouldn't crash the app, but instead show a warning indicating that the addon might not work as expected. Since fingerprinting and ember-cli-ifa are usually only enabled in production builds and ember-cli-storybook is aimed more at development builds that seems like a reasonable tradeoff until ember-cli-storybook can fix how it builds the HTML file.
    Turbo87 committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    89d76dd View commit details
    Browse the repository at this point in the history