Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream issue with node-sass and foundation components #40

Closed
wzrdtales opened this issue Apr 7, 2015 · 14 comments
Closed

Upstream issue with node-sass and foundation components #40

wzrdtales opened this issue Apr 7, 2015 · 14 comments

Comments

@wzrdtales
Copy link

The current beta5 of node-sass introduced some bugs together with the foundation scss. An issue on the upstream project is open.

This leads to the behavior, that ember-cli does not compile the sccs of foundation anymore, with the following error:

File: bower_components/foundation/scss/foundation/components/_forms.scss (335) expected a variable name (e.g. $x) or ')' for the parameter list for url

To anyone else having this problem:
downgrade your node-sass version in the ember-cli-sass module to beta4 fixes this problem.

Upstream Issues:
sass/libsass#1059
sass/node-sass#840

@laantorchaweb
Copy link

I have the same problem, I updated ember-cli and my project to the last version of ember-cli and I got this problem.

@seriousben
Copy link

Is there a way to downgrade a sub-package without using a shrinkwrap file?

@blisst
Copy link

blisst commented Apr 9, 2015

+1 to @seriousben on ways to downgrade the sub-package.

For anyone like me who had trouble with this, to fix this error you actually have to go into
node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/package.json and change the node-sass dependency to 3.0.0-beta.4.

@simonexmachina
Copy link
Collaborator

Downgrading to ember-cli-sass@3.0.x should also fix this problem (there's obviously issues with the node-sass beta).

@simonexmachina
Copy link
Collaborator

See #44 for details on this issue.

@simonexmachina
Copy link
Collaborator

I've also published ember-cli@4.0.0-beta.4 which fixes the version of node-sass to 3.0.0-beta.4 to avoid this issue with Foundation. I'll publish another version when this issue is resolved.

@wzrdtales
Copy link
Author

The current master branches of the upstream projects have the bugs fixed, but don't know when they want to release the new version. But anyway @aexmachina sticking to a specific version while a beta is so far the best one can and should do. If you publish the new version I suggest you also stick to the new release and not including the new ones already. While a running beta we have to expect, that things like this happen.

@simonexmachina
Copy link
Collaborator

So, does beta.4 not resolve your issue?

@wzrdtales
Copy link
Author

@aexmachina never said this ;) as also pointed out in my initiual issue it does, I was talking about the future releases of node-sass/libsass

@laantorchaweb
Copy link

@aexmachina the beta.4 is working fine, thanks!

@simonexmachina
Copy link
Collaborator

node-sass is now a peerDependency, so you can specify which version of node-sass@3.x to use in your package.json file.

@wzrdtales
Copy link
Author

@aexmachina the peer dependency is not correctly configured, there is also already an issue to this open.
#46

@simonexmachina
Copy link
Collaborator

@wzrdtales I'm not sure I understand what you're saying. See #44 for details on the resolution. Please reopen if you've still got an issue.

@simonexmachina
Copy link
Collaborator

Yes @wzrdtales, that's been fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants