Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-Url not parsed (3.2 regression) #1059

Closed
wzrdtales opened this issue Apr 7, 2015 · 4 comments
Closed

Data-Url not parsed (3.2 regression) #1059

wzrdtales opened this issue Apr 7, 2015 · 4 comments

Comments

@wzrdtales
Copy link

Hello together,

Since node-sass@3.0.0-beta.5 the errors below occur, I have tested it with node-sass@3.0.0-beta.4 and everything works fine again.

The following error occurs:
Error: File: bower_components/foundation/scss/foundation/components/_forms.scss (335) expected a variable name (e.g. $x) or ')' for the parameter list for url.

So there seems to be some errors while compiling the foundation scss components.

The line contains the following:

background-image: url(data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZlcnNpb249IjEuMSIgeD0iMTJweCIgeT0iMHB4IiB3aWR0aD0iMjRweCIgaGVpZ2h0PSIzcHgiIHZpZXdCb3g9IjAgMCA2IDMiIGVuYWJsZS1iYWNrZ3JvdW5kPSJuZXcgMCAwIDYgMyIgeG1sOnNwYWNlPSJwcmVzZXJ2ZSI+PHBvbHlnb24gcG9pbnRzPSI1Ljk5MiwwIDIuOTkyLDMgLTAuMDA4LDAgIi8+PC9zdmc+);
@mgreter
Copy link
Contributor

mgreter commented Apr 7, 2015

Will be fixed by #1051. IMO libsass/url will do as a test case here, since this has not been passing before that fix and it contains several data-urls, as the OP reported.

@mgreter
Copy link
Contributor

mgreter commented Apr 7, 2015

I'm pretty sure all reported issues have been fixed in latest master!
Please test with latest master if you can and report back! Thank you!

@mgreter mgreter closed this as completed Apr 7, 2015
@stefanpenner
Copy link

@mgreter which version will that release be?

@wzrdtales
Copy link
Author

@mgreter I can confirm the master fixes the data-url issue. There are still issues together with foundations components scss.

Have posted the test results there:
sass/node-sass#840 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants