dependentKey common validator options #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready for review 😺 |
| function register(fullName, factory) { | ||
| (registry || container).register(fullName, factory); | ||
| } | ||
| function register(fullName, factory) { |
There was a problem hiding this comment.
Why was leading whitespace added in front of these lines?
There was a problem hiding this comment.
woah no idea. Let me fix that
|
I left one small comment, but looks good other than that. In the future, could we keep the auto-generated doc updates in a separate commit than the main code and docs changes? It makes reading the diff somewhat more difficult (honestly, it would be nice if we could avoid checking in the generated files but that is a whole other issue). |
offirgolan
force-pushed
the
dependent-keys
branch
from
e6873d3
to
a194542
Compare
offirgolan
added a commit
that referenced
this pull request
Sep 21, 2015
dependentKey common validator options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #27