Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ember 3.10, drops support for decorators #641

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Support ember 3.10, drops support for decorators #641

merged 1 commit into from
Jun 4, 2019

Conversation

GavinJoyce
Copy link
Contributor

@GavinJoyce GavinJoyce commented May 28, 2019 •
edited
Loading

extracted from GavinJoyce#1
fixes #640 and resolves some of the issues described in #635

This PR is a breaking change as it drops support for decorators which have proven somewhat unstable. They were introduced a year ago in #583 so they are likely used by some apps. A good path forward would be to create ember-cp-validations-decorators which can depend on this addon and provide decorators support.

@GavinJoyce GavinJoyce force-pushed the gj/ember-3.10 branch 7 times, most recently from 8e24bd9 to 8c49695 Compare May 28, 2019 16:01
@GavinJoyce GavinJoyce mentioned this pull request May 29, 2019
Closed
@GavinJoyce GavinJoyce force-pushed the gj/ember-3.10 branch 2 times, most recently from 2935149 to 8ba9fec Compare May 29, 2019 09:09
@GavinJoyce GavinJoyce changed the title [WIP] support ember 3.10 Support ember 3.10, drops support for decorators May 29, 2019
@GavinJoyce GavinJoyce mentioned this pull request May 29, 2019
Closed
@GavinJoyce
Copy link
Contributor Author

This is passing on all scenarios except for beta and canary:

Screen Shot 2019-05-29 at 10 27 31

I've opened an issue to track that: #642

This was referenced May 29, 2019
Open
Open
@GavinJoyce
Copy link
Contributor Author

We're running this in production for @intercom at the moment

@cah-danmonroe
Copy link

cah-danmonroe commented Jun 2, 2019 •
edited
Loading

GavinJoyce/ember-cp-validations.git#8ba9fec36a2b3269bb95b66b0a2c68a832d6921d Fixes over 70 errors we had going from 3.9 to 3.10. Please merge

@offirgolan
Copy link
Collaborator

@GavinJoyce thanks for taking the time to resolve all of the current issues! Once this PR gets merged, I'll release a new beta version.

If the decorator support has been causing so many issues, I say we remove it altogether and I'll make a note of it in the new beta version's changelog. Feel free to remove it completely if thats necessary to get this working in 3.10+.

@GavinJoyce
Copy link
Contributor Author

@offirgolan I've removed the remaining references to decorators, this should be good to go now

@offirgolan offirgolan merged commit e037c99 into adopted-ember-addons:master Jun 4, 2019
@offirgolan
Copy link
Collaborator

Thanks @GavinJoyce! Released under v4.0.0-beta.9.

@offirgolan offirgolan mentioned this pull request Jun 4, 2019
Closed
2 tasks
@Alonski
Copy link
Member

Alonski commented Jun 4, 2019

Awesome work @GavinJoyce !!!

@jderr-mx
Copy link

jderr-mx commented Jun 4, 2019

Awesome work, thank you!

@GavinJoyce GavinJoyce deleted the gj/ember-3.10 branch June 4, 2019 19:04
@alejandrodevs
Copy link

Awesome. Thank you all!

@BryanCrotaz
Copy link

BryanCrotaz commented Oct 4, 2019 •
edited
Loading

I'm seeing this bug with beta 9 and ember 3.10.2

Edit: IGNORE - npm had pulled in two versions of this addon

This was referenced Oct 24, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offirgolan offirgolan offirgolan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken with Ember 3.10.0
7 participants
@GavinJoyce @cah-danmonroe @offirgolan @Alonski @jderr-mx @alejandrodevs @BryanCrotaz