Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export hasValidations decorator for es6 style models #583

Merged
merged 4 commits into from
Apr 16, 2018

Conversation

danielspaniel
Copy link
Contributor

@danielspaniel danielspaniel commented Apr 14, 2018

Resolves #556

Changes proposed:

  • export a new function hasValidations class level decorator which allows you to add validations to an es6 style ember data model or component

Tasks:

  • Added test case(s)
  • Updated documentation

@danielspaniel
Copy link
Contributor Author

ember-beta has a bug that prevents build from succeeding when trying to test against it, so i put that in the tests that were allowed to fail. This setting makes sense anyway .. because beta and canary are not usually stable, and to require them to pass for CI to pass seems a bit unreasonable.

@offirgolan
Copy link
Collaborator

@danielspaniel this is awesome! Thanks for taking the time to get this done.

@offirgolan offirgolan merged commit 580cced into adopted-ember-addons:master Apr 16, 2018
@danielspaniel
Copy link
Contributor Author

your welcome @offirgolan .. i am surprised no one did this before because you kinda need this if you make models in class based style

@offirgolan
Copy link
Collaborator

They probably have but you're the only one to open a PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants