Support Ember 3.13 (redux) #668
Conversation
This is not included in Array in IE 11.
|
Are there plans on merging this anytime soon? @offirgolan |
|
@offirgolan tests are passing 🎉 |
| @@ -1040,7 +1040,8 @@ module('Integration | Validations | Factory - General', function(hooks) { | |||
| assert.equal(child.get('validations.errors.length'), 1); | |||
| }); | |||
|
|
|||
| test('call super in validations class with no super property', function(assert) { | |||
| // https://github.com/offirgolan/ember-cp-validations/pull/656 | |||
| skip('call super in validations class with no super property', function(assert) { | |||
There was a problem hiding this comment.
do we not want to address this before moving forward here?
There was a problem hiding this comment.
Decision from @offirgolan was to skip for now. At this point getting this updated for Ember 3.13 is getting past critical as it's a blocker for many apps to provide feedback on the Octane beta.
There was a problem hiding this comment.
okay... I would just be worried about apps not working correctly if we skip this test. 🤔
There was a problem hiding this comment.
Me too, I don't actually know what any of this stuff does! I'm just playing referee to get the approved path merged. I'm happy to investigate and do more, but getting this merged has been a very long process so far. Makes me hesitant to add any more complexity that could delay it further.
There was a problem hiding this comment.
@Turbo87 skipping as this is already broken on the latest beta. Will have to circle back and figure out a good solution for this.
|
Released in |
|
Yay! Thanks!! |
ghost
mentioned this pull request
Re-bases and Supersedes and closes #662 and #653
I couldn't figure out a practical way to keep helping move this along in the original branch since it needed a rebase so I created a new one. Hope that is ok @offirgolan. I believe this is the last thing needed to support Ember 3.13 moving forward.