Update ember-cli to 3.28 #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| import ArrayProxy from '@ember/array/proxy'; | |||
| import ObjectProxy from '@ember/object/proxy'; | |||
| import { assign } from '@ember/polyfills'; | |||
| import { isHTMLSafe } from '@ember/string'; | |||
| import { isHTMLSafe } from '@ember/template'; | |||
There was a problem hiding this comment.
I think this is a breaking change, so NOTE for whoever releases this library next, we need to bump the major
There was a problem hiding this comment.
tho, I guess Ci will tell us
|
This is a good place to start -- let's merge, and then iterate on the workflow to get things green |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First iteration to get the addon up to date. There are still many deprecations and super old dependencies like
ember-cli-changelog(babel 5). So any feedback is appreaciated.