Lint everything #712
Merged
Lint everything #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsmanuel
force-pushed
the
lint-everything
branch
2 times, most recently
from
4625bca
to
8949ad1
Compare
fsmanuel
force-pushed
the
lint-everything
branch
from
8949ad1
to
dd3c3b4
Compare
fsmanuel
force-pushed
the
lint-everything
branch
from
e4bbb9e
to
6654542
Compare
|
@NullVoxPopuli What do you think which versions of ember should we support? As you already mentioned here: #711 (comment) the new release should be a major bump. |
|
yup, sounds good to me. I don't think it makes sense to support ember pre-octane |
fsmanuel
force-pushed
the
lint-everything
branch
2 times, most recently
from
d1c9640
to
06a4477
Compare
fsmanuel
force-pushed
the
lint-everything
branch
from
06a4477
to
cdebc1d
Compare
|
@NullVoxPopuli I updated the PR description ^^ and would suggest that I open a followup PR with the changes to the template transform (which I already did) to keep this PR focused. |
|
@NullVoxPopuli Thanks for merging. Wanna add the internal label? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup on #711 to get CI green.
Most of the commit messages should be self explanatory and it should be easy to review commit by commit.
Failing scenarios: The release, beta and canary runs still fail. The error is:
and is at least caused by the
htmlbars-plugins/v-get.jstemplate transform and maybe other dependencies.I would suggest that I open a followup PR with the changes to the template transform (which I already did - 7f98630) to keep this PR focused.