Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update active-model-adapter to 3.0.1 #476

Merged

Conversation

Techn1x
Copy link
Contributor

@Techn1x Techn1x commented Dec 3, 2022

This PR is helping out the efforts for ember v4 #444

active-model-adapter 2 depends on ember-cli-babel 6 while also using EAI, which is a blocker to ember-auto-import v2
active-model-adapter 3 does not have that issue.
active-model-adapter 4 is also available, but it requires ember-auto-import v2

So active-model-adapter 3 is a nice middle ground for now, until this addon is on EAI2


Bumps ember-maybe-import-regenerator to v1 - one less dependency on ember-cli-babel 6


We might want to consider bumping to ember-data 3.25 - it updates ember-inflector so is one less thing using ember-cli-babel 6, and still works with ember-data-model-fragments (well, the tests pass)


ember-django-adapter 2.1.1 is a little concerning, not much activity and is stuck on ember-cli-babel 6 and ember-inflector 2. It might be a blocker for EAI2 efforts? (not sure) - either way, I've put a PR up over there to see what happens dustinfarris/ember-django-adapter#263

@Techn1x
Copy link
Contributor Author

Techn1x commented Dec 10, 2022

@patocallaghan this should help with getting EDFG to ember-auto-import v2

Not sure if it passes tests or not - running the CI/workflow seems to need maintainer approval

@patocallaghan
Copy link
Collaborator

Brilliant work @Techn1x 👏 Will try review later

@patocallaghan patocallaghan merged commit f773bcf into adopted-ember-addons:master Dec 14, 2022
@patocallaghan
Copy link
Collaborator

Thanks @Techn1x 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants