Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate releases #309

Merged
merged 3 commits into from
Feb 29, 2020
Merged

Conversation

jelhan
Copy link
Collaborator

@jelhan jelhan commented Feb 27, 2020

This setups release-it and lerna-changelog to automate the release process. It also documents the required process in RELEASE.md.

Before doing the release the pull requests must be labeled correctly to be picked up by lerna-changelog.

This is based on rwjblue/create-rwjblue-release-it-setup. The first commit uses the current defaults. Second commits applies the changes proposed in rwjblue/create-rwjblue-release-it-setup#15.

It's splitted in two commits to ease review. Please squash on merging.

@jelhan jelhan requested a review from Alonski February 27, 2020 13:48
@jelhan
Copy link
Collaborator Author

jelhan commented Feb 27, 2020

error semver@7.1.3: The engine "node" is incompatible with this module. Expected version ">=10". Got "8.17.0"

Seems like a dependency dropped node 8 support without doing a major release. 😞

release-it has already dropped node 8 support. Will rebase after #308 is merged.

@gilest
Copy link
Collaborator

gilest commented Feb 27, 2020

Cool tooling. Looks good to me 👀

I have gone through the PRs since the last version and tried to label them. Probably worth double-checking the labels I have used are correct.

@jelhan jelhan mentioned this pull request Feb 27, 2020
6 tasks
@jelhan
Copy link
Collaborator Author

jelhan commented Feb 27, 2020

Rebased after #308 has been merged. Tests should pass now.

@jelhan
Copy link
Collaborator Author

jelhan commented Feb 27, 2020

I have gone through the PRs since the last version and tried to label them. Probably worth double-checking the labels I have used are correct.

You motivated me to do the same for the other PRs and update the changelog which was very outdated. This also includes a nice example of how the generated changelog looks like into this pull request.

@gilest
Copy link
Collaborator

gilest commented Feb 28, 2020

I think this branch needs a rebase.

Love the new changelog ❤️

@jelhan
Copy link
Collaborator Author

jelhan commented Feb 28, 2020

Rebased.

@jelhan jelhan merged commit 54139d9 into adopted-ember-addons:master Feb 29, 2020
@Alonski
Copy link
Member

Alonski commented Feb 29, 2020

Sorry for not reviewing but it seems that you both are doing an amazing job! @jelhan and @gilest
Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants