Drop support for node 8 #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
Thanks a lot for picking this one up so quickly. We should consider adding a Compatibilty chapter to README.md as it's now in default blueprint: https://github.com/ember-cli/ember-addon-output#compatibility Do you want to add it as part of this pull request? Otherwise we could also do in a separate pull request.
|
Have added Compatability section. The |
jelhan
approved these changes
Feb 27, 2020
Merged
|
@jelhan you may merge when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #306
This is all I can think of doing.
Let's see if the tests pass 🤷♀