Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.0 throws an EEXIST: file already exists on app build #417

Closed
maartenparmentier opened this issue Jan 29, 2020 · 8 comments · Fixed by #423
Closed

2.1.0 throws an EEXIST: file already exists on app build #417

maartenparmentier opened this issue Jan 29, 2020 · 8 comments · Fixed by #423
Labels

Comments

@maartenparmentier
Copy link

maartenparmentier commented Jan 29, 2020

Hi there!

We've been using this addon for ages and never had issues.
The last release (2.1.0) however breaks our build

EmberCli::BuildError - :frontend has failed to build: Error: EEXIST: file already exists, symlink 'xxx/frontend/node_modules/ember-infinity/app/templates/components/infinity-loader.js' -> '/var/folders/f_/3tsbxd_121qfwtpmt9bbn_qc0000gn/T/broccoli-53081Is43Nt4o2pvj/out-787-broccoli_persistent_filter_template_compiler/intuo-ember/templates/components/infinity-loader.js'

We are using a custom template (generated by the ember generate infinity-template command stated in the readme)

I think it's related to this ember-cli issue. But I can't seem to fix it 😬

@snewcomer
Copy link
Collaborator

Woah. Yes you are correct. That would definitely prevent you from upgrading. I'll see if I can look into it tomorrow.

@snewcomer snewcomer added the bug label Jan 30, 2020
@snewcomer
Copy link
Collaborator

If this is a long outstanding bug, we may need to simply change the blueprint to generate a new filename. What do you think? It was a "breaking change" from the perspective of the framework when I introduced the templated infinity-loader in this addon for 2.1.0. I'm not sure of another solution....

@maartenparmentier
Copy link
Author

I think that's a valid idea and solution. 👍

@snewcomer
Copy link
Collaborator

Hm. A slight nuisance with that this approach would require you to import and extend from the addon's infinity-loader.js class...We may have to suggest that approach in the README.

I'm also wondering if the errors is due to how we are exporting our template in app/. Will look into that next.

@brunoocasali
Copy link
Contributor

Hey @snewcomer how can I do the approach you mentioned above? (I'm really interested in this fix, my build is broken too 💃)

@mk-conn
Copy link

mk-conn commented Mar 11, 2020

Hey @snewcomer how can I do the approach you mentioned above? (I'm really interested in this fix, my build is broken too 💃)

Yep, would be interested in that workaround too... :)

snewcomer added a commit that referenced this issue Mar 12, 2020
Introducing a templated infinity-loader broke this. close #417
@snewcomer
Copy link
Collaborator

snewcomer commented Mar 12, 2020

@maartenparmentier I'm going to give #423 a try...I'm unsure that, if because it is exporting the template, that is is causing the build issues you are seeing. By removing it, it "may" help.

2.1.1

Lmk if it helps! I can reopen if it doesn't.

@maartenparmentier
Copy link
Author

maartenparmentier commented Mar 13, 2020

@snewcomer It works! Thank you for this 🙏 👍

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants