Convert to monorepo #591
Merged
Convert to monorepo #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemelia
requested changes
Feb 9, 2022
| }, | ||
| "scripts": { | ||
| "build": "ember build --environment=production", | ||
| "deploy": "yarn ember github-pages:commit --message \"Deploy gh-pages from commit $(git rev-parse HEAD)\"; git push; git checkout -", |
There was a problem hiding this comment.
Will this still work with the changed paths?
There was a problem hiding this comment.
@lukemelia I don't see why it wouldn't work:
ember-cli-github-pages is dependency of the test-app hence all should just work.
The only difference if that yarn deploy command need to be run from /test-app folder instead of root folder.
unless I'm missing something
There was a problem hiding this comment.
Let's try it after merging and find out!
This follows [Porting an Addon to V2 guide](https://github.com/embroider-build/embroider/blob/main/PORTING-ADDONS-TO-V2.md) This is prerequisite for v2 addon conversion
lukemelia
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows Porting an Addon to V2 guide
This is prerequisite for v2 addon conversion