topic/289-typescript #293
Merged
topic/289-typescript #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarn upgrade ember-cli@~3.27.0 Will need to use `ember install`, and this is broken in 3.28.0.
eslint-plugin-ember@10.5.5, prettier@2.4.1, qunit@2.17.2, release-it@14.11.6, broccoli-funnel@3.0.8
ember install ember-cli-typescript Manually moved ember-cli-typescript from devDependencies to dependencies. See https://docs.ember-cli-typescript.com/ts/with-addons#key-differences-from-apps
yarn add --dev @typescript-eslint/eslint-plugin @typescript-eslint/parser typedoc
Closed
jherdman
requested changes
Sep 27, 2021
| "babel-eslint": "^10.1.0", | ||
| "broccoli-asset-rev": "^3.0.0", | ||
| "ember-cli": "~3.28.0", | ||
| "ember-cli": "~3.27.0", |
There was a problem hiding this comment.
This seems like a mistake.
There was a problem hiding this comment.
No, it is a workaround for a bug in ember-cli 3.28.0. Now that ember-cli-typescript is installed, we could upgrade back to 3.28.0, but I would wait for 3.28.1 to be released.
There was a problem hiding this comment.
Just this change left.
Edit: just saw your comment above.
jherdman
requested changes
Sep 29, 2021
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| # compiled output | |||
| /dist/ | |||
| /doc/ | |||
There was a problem hiding this comment.
Should this change be copied to .npmignore too?
There was a problem hiding this comment.
Yes. I did not notice the project had a .npmignore. I have pushed this change.
jherdman
approved these changes
Sep 29, 2021
|
Many thanks for your contribution! 😍 |
|
Resolves #289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the basic wiring for TypeScript and the conversion of one JavaScript file to TypeScript (as a first step for issue 289).