Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presence): fix doc and add option to allow empty string #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GreatWizard
Copy link
Contributor

Problem

The current ignoreBlank option said it treats an empty string as not present.
But as you can see in the test, this exact use case throw an error.

Current solution

  • Add test about the failing use case
  • Add a new allowEmpty option to handle that specific use case and not break the current integration
  • Update the JSDoc accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant