Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing emberx-file-input in an addon #30

Closed
xcambar opened this issue Jul 19, 2016 · 1 comment
Closed

Importing emberx-file-input in an addon #30

xcambar opened this issue Jul 19, 2016 · 1 comment
Assignees
Labels

Comments

@xcambar
Copy link
Contributor

xcambar commented Jul 19, 2016

Unfortunately, #28 reverts #26 (aka, remove ember-cli-import-polyfill, mostly) which allowed the addon to be imported from another addon.

It breaks an important use case for us, as we import this addon from other (private) addons. I'm taking the opportunity to start the discussion here about what should be the best approach, considering that ignoring this use case was intentional.

FYI, the polyfill is meant for an upcoming feature in Ember 2.7 that allows nested addons. See ember-cli/ember-cli#6043 for the implementation.

ping @Robdel12 @cowboyd

Robdel12 added a commit that referenced this issue Jul 19, 2016
This was broken because when I updated ember-cli I forgot to add this
dep back into the package.json file.
@Robdel12
Copy link
Collaborator

Woops, at first I thought it went out with a release. Thankfully it didn't :)

Thanks for bringing this to my attention (again), I opened a PR and once those tests pass I'm going to merge it. 🎉

@Robdel12 Robdel12 added the bug label Jul 19, 2016
@Robdel12 Robdel12 self-assigned this Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants