[BUGFIX beta] Test nested addon import #6043
Conversation
| this.timeout(360000); | ||
|
|
||
| before(function() { | ||
| return createTestTargets(appName); |
There was a problem hiding this comment.
since this part here takes quite a long time it might be beneficial to combine this with other "slow" tests. e.g. if there is something like an addons-smoke-test-slow already then you should probably just add it there instead.
xcambar
force-pushed
the
test_nested_addon_import
branch
4 times, most recently
from
a559f8d
to
6584bc5
Compare
|
@xcambar I just checked that the current |
|
Thanks for investigating. FWIW, I'm currently trying to split the changes into smaller chunks and see when/why it breaks master. |
|
Looks good (and green)! Can you squash down to a single commit, and prefix with |
xcambar
force-pushed
the
test_nested_addon_import
branch
from
6ce4b41
to
919c648
Compare
xcambar
changed the title
|
done |
|
@homu r+ |
|
📌 Commit 919c648 has been approved by |
|
⚡ Test exempted - status |
[BUGFIX beta] Test nested addon import refs #5990 This PR updates `Addon.prototype.import` (https://github.com/ember-cli/ember-cli/pull/6043/files#diff-f1e1923c0440a385f51d2a81c0e53b64R448) as per @machty's implementation (see https://github.com/machty/ember-maybe-import-regenerator/blob/master/index.js#L38-L50). It also adds a smoke test that builds an app with one addon that itself requires 2 more (hence nested) addons. These addons imports a file each, one with the new `this.import(asset)`, the other with the current `app.import(asset)`. The PR makes sure that independently from the addon developer's preference (or history), the import binds to the correct app, thanks to @machty's implementation. @Turbo87 Though I let the smoke test at its initial place, I am more than willing to move it to a more appropriate location, your recommandations are welcome. As a follow up to #5990, ping @rwjblue and @nathanhammond.
refs #5990
This PR updates
Addon.prototype.import(https://github.com/ember-cli/ember-cli/pull/6043/files#diff-f1e1923c0440a385f51d2a81c0e53b64R448) as per @machty's implementation (see https://github.com/machty/ember-maybe-import-regenerator/blob/master/index.js#L38-L50).It also adds a smoke test that builds an app with one addon that itself requires 2 more (hence nested) addons. These addons imports a file each, one with the new
this.import(asset), the other with the currentapp.import(asset).The PR makes sure that independently from the addon developer's preference (or history), the import binds to the correct app, thanks to @machty's implementation.
@Turbo87 Though I let the smoke test at its initial place, I am more than willing to move it to a more appropriate location, your recommandations are welcome.
As a follow up to #5990, ping @rwjblue and @nathanhammond.