Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce workload on ClassLoadingLoadTest if special JIT options are used #306

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Reduce workload on ClassLoadingLoadTest if special JIT options are used #306

merged 1 commit into from
Nov 5, 2019

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam commented Nov 4, 2019 •
edited
Loading

  • Reduces workload to half of normal when special slow running JIT modes are used

Resolves: adoptium/openj9-systemtest#104

Signed-off-by: Mesbah_Alam@ca.ibm.com Mesbah_Alam@ca.ibm.com

@Mesbah-Alam
Copy link
Contributor Author

Tested here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/995/console

@Mesbah-Alam Mesbah-Alam self-assigned this Nov 4, 2019
@Mesbah-Alam Mesbah-Alam added the bug label Nov 4, 2019
@pshipton
Copy link
Contributor

pshipton commented Nov 4, 2019

Looking at
https://ci.eclipse.org/openj9/job/Test_openjdk8_j9_special.system_x86-64_windows_Nightly/523

The runs with -Xjit:count=0 are fine and shouldn't be changed.

  • ClassLoadingTest_special_15 about 2 minutes
  • ClassLoadingTest_special_16 about 6 minutes
  • ClassLoadingTest_special_18 about 4 minutes
  • ClassLoadingTest_special_19 about 3 minutes
  • ClassLoadingTest_special_23 about 1 minute

The runs with -Xjit:count=0,optlevel=warm,gcOnResolve,rtResolve only run with -Xnocompressedrefs so they are skipped on Windows.

Looking at https://ci.eclipse.org/openj9/job/Test_openjdk11_j9_special.system_x86-64_linux_xl_Personal/60 the runs with -Xjit:count=0,optlevel=warm,gcOnResolve,rtResolve take a long time (45 min and 10 min), so reducing the load for these is fine.

@Mesbah-Alam
Reduce workload on ClassLoadingLoadTest if special JIT options are used
1660028 
Signed-off-by: Mesbah_Alam@ca.ibm.com <Mesbah_Alam@ca.ibm.com>
@Mesbah-Alam Mesbah-Alam force-pushed the configure-class-loading-test-for-specialmodes branch from 427f893 to 1660028 Compare November 4, 2019 22:17
@Mesbah-Alam
Copy link
Contributor Author

Removed -Xjit:count=0 from the list of options for which to run reduced load.

@Mesbah-Alam Mesbah-Alam merged commit 3104b59 into adoptium:master Nov 5, 2019
@Mesbah-Alam Mesbah-Alam mentioned this pull request Nov 5, 2019
Closed
@Mesbah-Alam Mesbah-Alam deleted the configure-class-loading-test-for-specialmodes branch November 15, 2019 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

Assignees

@Mesbah-Alam Mesbah-Alam

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Excessive duration of system tests
2 participants
@Mesbah-Alam @pshipton