-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parsers & Perf Graph for AcmeAir #119
Comments
FYI @jiayaolinn |
piyush286
changed the title
Add Parsers for AcmeAir
Add Parsers & Perf Graph for AcmeAir
Jun 25, 2019
@jiayaolinn You'll have to wait for #106 to be fixed before you can add a graph for AcmeAir since Perf Graphs are currently busted because of #73. @sophiaxu0424 will be working on #106 after she finishes her current PR. |
jiayaolinn
pushed a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Jun 25, 2019
Issue: adoptium#119 Signed-off-by: Jiayao Lin <jiayao@jiayaos-mbp.war.can.ibm.com>
jiayaolinn
pushed a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Jun 25, 2019
Issue: adoptium#119 Signed-off-by: Jiayao Lin <jiayao@jiayaolinn@gmail.com>
jiayaolinn
pushed a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Jun 25, 2019
Issue: adoptium#119 Signed-off-by: Jiayao Lin <jiayaolinn@gmail.com>
jiayaolinn
pushed a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Jun 25, 2019
- Updated Regex so that it would be safer - Changed variant name, Throughput and added a unique string in the regex for easier identificatio Issue: adoptium#119 Signed-off-by: Jiayao Lin <jiayaolinn@gmail.com>
jiayaolinn
added a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Dec 16, 2019
- Based on ODM.jsx, added a perf graph for AcmeAir - Added parsers for adding information to Node version Issue adoptium#119 Issue adoptium#106 Signed-off-by: Jiayao Lin <jiayaolinn@gmail.com>
jiayaolinn
added a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Dec 19, 2019
- Based on ODM.jsx, added a perf graph for AcmeAir - Added parsers for adding information to Node version Issue adoptium#119 Issue adoptium#106 Signed-off-by: Jiayao Lin <jiayaolinn@gmail.com>
jiayaolinn
added a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Dec 24, 2019
- Based on ODM.jsx, added a perf graph for AcmeAir - Added parsers for adding information to Node version Issue adoptium#119 Issue adoptium#106 Signed-off-by: Jiayao Lin <jiayaolinn@gmail.com>
jiayaolinn
added a commit
to jiayaolinn/openjdk-test-tools
that referenced
this issue
Jan 14, 2020
- Based on ODM.jsx, added a perf graph for AcmeAir - Added parsers for adding information to Node version Issue adoptium#119 Issue adoptium#106 Signed-off-by: Jiayao Lin <jiayaolinn@gmail.com>
Closing this since all related work to this issue has been completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem Description
Parsers need to be added for the following benchmarks so that they can be monitored using the existing tools (Perf Graphs) and tools under development (Tabular View), allowing the summarization and visualization of the perf results.
Benchmarks Parsers to Add
Acmeair: https://github.com/acmeair/acmeair
Octane: https://chromium.github.io/octane/
Steps for Adding a Parser
I'm adding some steps here that I provided in the internal GitHub so that others can refer to this documentation for adding more parsers in future.
Our parsers in Test Result Summary Service (https://github.com/AdoptOpenJDK/openjdk-test-tools/tree/master/TestResultSummaryService/parsers) expect all the results to be in the Jenkins output, so that we don't need to parse results from different files. Hence, we might need to output the results from some log file to the main Jenkins output. If TRSS is monitoring that Jenkins pipeline and it's marked as "Perf" in the build monitoring list (as we discussed in our meeting), then it would parse all the results once the builds are done.
All Jenkins builds should output the following info (Testci string, Benchmark Name, Benchmark Variant, Product) at the start of each benchmark build.
Sample Output:
We use the following regexes in TRSS for parsing that info as shown below:
For startup and footprint, we start an app multiple times (usually 8 times). Before each run, we print "Warm run <Iteration#>" (i.e.
outerRegex
), which works as an outer regex to get smaller section to parse. Then we use another regex (i.e.regex
) to parse the metric value from each smaller section. So we can parse results for each iteration. You can see sample parsed data here (#73 (comment)).For throughput, we just use one regex (i.e. "Throughput: ") for AcmeAir. AcmeAir can use the same parser for startup, which is already there in the code.
Snippet for Liberty Startup
https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/524d16e3784c17f4af6cee75f9105eb929397792/TestResultSummaryService/parsers/BenchmarkMetric.js#L13-L28
Sample Liberty AcmeAir Startup Job:
Sample Liberty AcmeAir Throughput Job:
To Add a Perf Graph
For adding a perf graph widget, you can refer to one of the existing perf graphs such as ODM: https://github.com/AdoptOpenJDK/openjdk-test-tools/blob/master/test-result-summary-client/src/Dashboard/Widgets/Graph/ODM.jsx
The text was updated successfully, but these errors were encountered: