Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore invalid build url when monitoring builds #4

Closed
llxia opened this issue Aug 24, 2018 · 0 comments
Closed

Ignore invalid build url when monitoring builds #4

llxia opened this issue Aug 24, 2018 · 0 comments
Assignees
@llxia
Labels
enhancement New feature or request
Projects
aqa-test-tools

Comments

@llxia
Copy link
Contributor

llxia commented Aug 24, 2018

Currently, we do not check the exception message. We try to connect to build url 5 times regardless what kind of exception we get and set the status to Done.

In fact, if the error is 404 (invalid url), we need to ignore this url. But for other errors (i.e., ESOCKETTIMEDOUT), we should retry and keep the build status to NotDone. In this way, we can try it later in the next round.
@llxia llxia self-assigned this Aug 24, 2018
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 24, 2018
@llxia
Check Jenkins query exception message
6eec1d0 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 24, 2018
@llxia
Check Jenkins query exception message
e3e4ec9 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia llxia mentioned this issue Aug 24, 2018
Merged
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 24, 2018
@llxia
Check Jenkins query exception message
aa0defc 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@smlambert smlambert added the enhancement New feature or request label Aug 24, 2018
@karianna karianna added this to To do in aqa-test-tools via automation Aug 27, 2018
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 30, 2018
@llxia
Check Jenkins query exception message
d475bff 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 30, 2018
@llxia
Check Jenkins query exception message
ff25ca2 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 30, 2018
@llxia
Check Jenkins query exception message
76fed85 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 30, 2018
@llxia
Check Jenkins query exception message
7916d26 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 30, 2018
@llxia
Check Jenkins query exception message
89a2341 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Aug 30, 2018
@llxia
Check Jenkins query exception message
918ad1b 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia llxia closed this as completed in #5 Aug 30, 2018
aqa-test-tools automation moved this from To do to Done Aug 30, 2018
llxia added a commit to llxia/openjdk-test-tools that referenced this issue Jan 7, 2019
@llxia
Check Jenkins query exception message
8c3aad4 
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llxia llxia

Labels
enhancement New feature or request
Projects
No open projects
aqa-test-tools
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smlambert @llxia