Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Jenkins query exception message #5

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Aug 24, 2018

Ignore invalid build url when the error is 404

Fixes: #4

Signed-off-by: lanxia lan_xia@ca.ibm.com

@llxia llxia requested a review from smlambert August 24, 2018 15:39
@karianna karianna added the bug Something isn't working label Aug 27, 2018
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Only minor cosmetic comments, please fix the indentation on lines 18-22 in BuildProcessor.js (shift left) and remove extra space after includes on line 17 in JenkinsInfo.js before merge.

@llxia llxia force-pushed the test branch 5 times, most recently from 7916d26 to 89a2341 Compare August 30, 2018 14:12
Ignore invalid build url when the error is 404

Fixes: adoptium#4

Signed-off-by: lanxia <lan_xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Aug 30, 2018

Reformatted both files. Thanks.

@llxia llxia merged commit d63a55c into adoptium:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants