Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release pipeline builds/smoke tests do not display well in Grid view #765

Closed
smlambert opened this issue Jan 12, 2023 · 4 comments · Fixed by #766
Closed

New release pipeline builds/smoke tests do not display well in Grid view #765

smlambert opened this issue Jan 12, 2023 · 4 comments · Fixed by #766
Assignees

Comments

@smlambert
Copy link
Contributor

There must be some funky new strings/naming to cope with as we now start to monitor
https://ci.adoptopenjdk.net/job/build-scripts/job/release-openjdk17-pipeline/ (and 8, 11, and 19)

Similar issue to #695, but worse because it is not clear what version or architecture mac_release, etc refer to, see below (or here).

Screen Shot 2023-01-12 at 11 41 39 AM

@smlambert
Copy link
Contributor Author

smlambert commented Jan 13, 2023

https://github.com/adoptium/aqa-test-tools/blob/master/test-result-summary-client/src/Build/Summary/ResultSummary.jsx#L108

The regex we use to tokenize the build name was created to apply to build names structure like jdk8u-windows-x64-temurin and now there are additional types of name to deal with that has -release- within it jdk8u-release-windows-x64-temurin and jdk11u-prototype-windows-aarch64-temurin, etc (related: adoptium/ci-jenkins-pipelines#494)

const regex = /^jdk(\d+).?-(\w+)-(\w+)-(\w+)/i;
const tokens = buildName.match(regex);

Screen Shot 2023-01-13 at 8 15 01 AM

Screen Shot 2023-01-13 at 8 16 05 AM

Screen Shot 2023-01-13 at 8 15 37 AM

So we end up losing the implementation info, and assigning wrong things to the wrong variables.
One fix can be to update the regex to add a non-capturing group using (?:) to ignore the words prototype or release if they are present. Also need to check if evaluation will be the word used instead of prototype.
/^jdk(\d+).?(?:-prototype|-release)?-(\w+)-(\w+)-(\w+)/i

In an ideal world, build and test would have aligned on a same naming schema, to avoid this fragile mapping step completely, but that ship may have sailed.

Another question to ask is whether the release and evaluation pipelines need to rename the child jobs or not.

@llxia
Copy link
Contributor

llxia commented Jan 13, 2023

Another question to ask is whether the release and evaluation pipelines need to rename the child jobs or not.

Personally, I do not see the need to rename the child jobs. Currently, the release and evaluation pipelines trigger some renamed jobs (i.e., build and smoke test job) and some existing jobs (i.e., AQA test jobs). IMO, this is not ideal.

@llxia
Copy link
Contributor

llxia commented Jan 13, 2023

Thanks @smlambert for updating TRSS for the current issue.

Regarding rename the child jobs, I will leave a comment at adoptium/ci-jenkins-pipelines#473 for a broader discussion.

@smlambert
Copy link
Contributor Author

FYI: I've just missed the regular Friday TRSS_Code_Sync, so triggering it manually now to pick up this change for use during pre-release dry run testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants