-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update regex to ignore extra words in buildName #766
Conversation
Signed-off-by: Shelley Lambert <slambert@gmail.com>
✅ Deploy Preview for eclipsefdn-adoptium-trss ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Shelley Lambert <slambert@gmail.com>
Note: I installed the Prettier plugin, which might be why the other changes in the file. Also there were updates to package-lock.json file, which I did not push, as I did not want to distract from the core change. (let me know if you want it pushed as part of this PR). |
There are 2 other regex in that file that may have been impacted by adoptium/ci-jenkins-pipelines#494 (on line55 and line129, though I am not immediately seeing an issue around those. Can raise a new issue and PR if we find it to be the case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smlambert
Thanks Lan, this will allow us to use TRSS for Jan release next week. We can have discussion in build issue as to whether child job names will continue to have this extra word in them (in which case the change to this regex, though it will still work for that case, could be reverted). |
Fixes #765
Update regex to use non-capture group to ignore extra words (release or evaluation)
Signed-off-by: Shelley Lambert slambert@gmail.com