Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update regex to ignore extra words in buildName #766

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

smlambert
Copy link
Contributor

@smlambert smlambert commented Jan 13, 2023

Fixes #765

Update regex to use non-capture group to ignore extra words (release or evaluation)

Signed-off-by: Shelley Lambert slambert@gmail.com

Signed-off-by: Shelley Lambert <slambert@gmail.com>
@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for eclipsefdn-adoptium-trss ready!

Name Link
🔨 Latest commit c233b50
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/63c17b660f38bf0009774b6a
😎 Deploy Preview https://deploy-preview-766--eclipsefdn-adoptium-trss.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Shelley Lambert <slambert@gmail.com>
@smlambert smlambert requested a review from llxia January 13, 2023 15:49
@smlambert
Copy link
Contributor Author

Previous to this change, the Grid view for release pipeline was broken and looked like this
Screen Shot 2023-01-13 at 10 52 49 AM

I've confirmed in the netlify preview that the regular way of naming jobs is not affected by this change (still works), and the new naming now also works (screen grab below).

Screen Shot 2023-01-13 at 10 51 15 AM

@smlambert
Copy link
Contributor Author

Note: I installed the Prettier plugin, which might be why the other changes in the file. Also there were updates to package-lock.json file, which I did not push, as I did not want to distract from the core change. (let me know if you want it pushed as part of this PR).

@smlambert
Copy link
Contributor Author

There are 2 other regex in that file that may have been impacted by adoptium/ci-jenkins-pipelines#494 (on line55 and line129, though I am not immediately seeing an issue around those. Can raise a new issue and PR if we find it to be the case.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smlambert

@llxia llxia merged commit 49d4bf6 into adoptium:master Jan 13, 2023
@smlambert
Copy link
Contributor Author

Thanks Lan, this will allow us to use TRSS for Jan release next week. We can have discussion in build issue as to whether child job names will continue to have this extra word in them (in which case the change to this regex, though it will still work for that case, could be reverted).

@smlambert smlambert deleted the issue765 branch May 23, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New release pipeline builds/smoke tests do not display well in Grid view
2 participants