Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jenkins: Parallel option should be ignored when num machines is 1 #4093

Closed
AdamBrousseau opened this issue Oct 27, 2022 · 2 comments · Fixed by #4102
Closed

Jenkins: Parallel option should be ignored when num machines is 1 #4093

AdamBrousseau opened this issue Oct 27, 2022 · 2 comments · Fixed by #4102

Comments

@AdamBrousseau
Copy link
Contributor

Describe the bug
If the number of machines, and therefore the number of child jobs, equals 1, I don't think we need to bother launching a child job.

To Reproduce
Launch a test with a parallel option and a build node label that only matches 1 machine

Expected behavior
Don't do parallel as it will create unnecessary overhead

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.
@AdamBrousseau
Copy link
Contributor Author

I didn't look at the code yet to see how feasible this is.

@pshipton
Copy link
Contributor

If we make this change, we could also change the parallel default in a grinder from "None" to (my preferred) "NodesByIterations".

llxia added a commit to llxia/openjdk-tests that referenced this issue Oct 28, 2022
@llxia
Update logic for Parallel option with num_machines=1
a61b1df 
resolve: adoptium#4093
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia llxia mentioned this issue Oct 31, 2022
Closed
llxia added a commit to llxia/openjdk-tests that referenced this issue Oct 31, 2022
@llxia
Update logic for Parallel option with num_machines=1
bd06526 
resolve: adoptium#4093
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia llxia mentioned this issue Oct 31, 2022
Merged
llxia added a commit to llxia/openjdk-tests that referenced this issue Nov 1, 2022
@llxia
Update logic for Parallel option with num_machines=1
fd5d68f 
resolve: adoptium#4093
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
llxia added a commit to llxia/openjdk-tests that referenced this issue Nov 1, 2022
@llxia
Update logic for Parallel option with num_machines=1
f4dfcac 
When running tests with Parallel option and num_machines=1, run tests serially.
Don't do parallel as it will create unnecessary overhead

resolve: adoptium#4093
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
smlambert pushed a commit that referenced this issue Nov 2, 2022
@llxia
Update logic for Parallel option with num_machines=1 (#4102)
d35e9d1 
When running tests with Parallel option and num_machines=1, run tests serially.
Don't do parallel as it will create unnecessary overhead

resolve: #4093
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia llxia mentioned this issue Nov 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Adoptium November 2022 Plan
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update logic for Parallel option with num_machines=1 llxia/openjdk-tests
2 participants
@AdamBrousseau @pshipton