Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Remove Parallel=Subdir feature #4101

Closed
llxia opened this issue Oct 31, 2022 · 1 comment · Fixed by #4112
Closed

Discussion: Remove Parallel=Subdir feature #4101

llxia opened this issue Oct 31, 2022 · 1 comment · Fixed by #4112

Comments

@llxia
Copy link
Contributor

llxia commented Oct 31, 2022

Parallel=Subdir feature was introduced before we had actual parallelization (i.e., Parallel=Dynamic or NodesByIterations). At that time, we ran tests in parallel according to subdir, which was used for external tests only. With the actual parallelization (i.e., Parallel=Dynamic), we do not use Parallel=Subdir feature anymore. The external tests are updated to use Parallel=Dynamic. As far as I know, this Parallel=Subdir feature is no longer used. I would like to propose removing this feature from our code base.

By removing Parallel=Subdir feature, it will make Parallel logic more simple and easy to add the enhancements (such as #4093 and #3986)

llxia added a commit to llxia/openjdk-tests that referenced this issue Nov 2, 2022
resolve: adoptium#4101
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@smlambert
Copy link
Contributor

I think this seems like a wise course of action. We no longer need this feature and removing it removes complexity and potential tech debt of supporting an unused feature.

@renfeiw renfeiw closed this as completed in 66436e6 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants