Enabling JVMTI tests for ibm jck8 #3703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlambert
requested changes
May 25, 2022
|
Also, the aqaTestPipeline.groovy change is not relevant and should be removed. The change in aqaTestPipeline.groovy was already committed into master dc686eb |
|
@ShelleyLambert @llxia Can you please review it now, earlier had some conflicts with origin |
llxia
reviewed
May 26, 2022
| <platform>.*zos.*</platform> | ||
| <impl>ibm</impl> | ||
| <version>8</version> | ||
| </disable> |
There was a problem hiding this comment.
Instead of adding a new <disable>, please update line 99 to <version>8+</version>
llxia
reviewed
May 26, 2022
jck/runtime.vm/playlist.xml
Outdated
| @@ -96,14 +96,9 @@ | |||
| <comment>Temporarily disabled on z/OS for backlog/issues/670</comment> | |||
| <platform>.*zos.*</platform> | |||
| <impl>ibm</impl> | |||
| <version>8+</version> | |||
| <version>11</version> | |||
There was a problem hiding this comment.
<version>11</version> should be removed
smlambert
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables JVMTI tests on all 64bit platforms for IBM JCK8.
Fixes: runtimes/backlog/issues/607
Signed off by : Soumya Biradar sobirada@in.ibm.com