Consume vendor specific exclude list #3942
Conversation
|
The following test shows that the dev specific exclude file is being consumed by the framework: |
|
Note: This PR should be delivered before we deliver changes to the internal tck repos for adding *-dev.jtx. |
| @@ -267,6 +268,16 @@ public static boolean generateJTB() throws Exception { | |||
| System.out.println("Unable to find additional excludes list file " + jtxFullPath); | |||
| jtxFullPath = ""; | |||
| } | |||
|
|
|||
| jtxDevFullPath = jckRoot + File.separator + "excludes" + File.separator + jckVersion + "-dev.jtx"; | |||
There was a problem hiding this comment.
Can we offer the option to pass in the full path, since in temurin-compliance case we are not able to add files to jckRoot, so we would have to host the exclude file elsewhere.
There was a problem hiding this comment.
Sure, I will add a new input variable (e.g. -customJtx) to JavasTestRunner for passing in full path to an exclude file.
There was a problem hiding this comment.
@smlambert - I have updated the PR. JavaTestRunner will now accepts a new input parameter called customJtx which can be used to supply a full (local) path to a custom jtx file. If supplied the custom jtx file will be appended to the excludeList property in the generated command (jtb) file.
Tested: Grinder_JCK/638.
(Note: The test was done using an internal machine where I pre-created a custom jtx file (/home/jenkins/mesbah/custom.jtx). It was then supplied viacustomJtx simply in CUSTOM_TARGET field (i.e. TARGET=jck_custom and CUSTOM_TARGET=api/java_beans/Beans/Beans.html customJtx=/home/jenkins/mesbah/custom.jtx).
(will share test output via slack).
There was a problem hiding this comment.
Thanks @Mesbah-Alam, I will run a similar test on the temurin-compliance server!
Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
Mesbah-Alam
force-pushed
the
add-support-for-jck-dev-jtx
branch
from
8098262
to
d1efe62
Compare
Consume vendor specific exclude list
Related : backlog/issues/885
Signed-off-by: Mesbah-Alam Mesbah_Alam@ca.ibm.com