Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If no custom JTX file is supplied, ensure it's not null #3952

Merged

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam commented Sep 7, 2022

This PR fixes an issue introduced by #3942 : If no custom JTX file is supplied, we need to ensure it's not null. Otherwise grinder jobs with tck targets will fail with a null value in generated command jtb.

Signed-off-by: Mesbah-Alam Mesbah_Alam@ca.ibm.com

Signed-off-by: Mesbah-Alam <Mesbah_Alam@ca.ibm.com>
@Mesbah-Alam
Copy link
Contributor Author

Test : Grinder_JCK/655

@Mesbah-Alam Mesbah-Alam marked this pull request as ready for review September 7, 2022 19:17
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit b3e2751 into adoptium:master Sep 7, 2022
@Mesbah-Alam Mesbah-Alam deleted the add-null-check-for-customJtx branch February 6, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants