Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker registry parameters for jenkins #3960

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add docker registry parameters for jenkins #3960

merged 1 commit into from
Sep 14, 2022

Conversation

LongyuZhang
Copy link
Contributor

Signed-off-by: Longyu Zhang longyu.zhang@ibm.com

@LongyuZhang
Copy link
Contributor Author

Test with Docker Registry parameters in grinder: hyc_grinder 27427

@LongyuZhang LongyuZhang mentioned this pull request Sep 13, 2022
Merged
@llxia
Copy link
Contributor

llxia commented Sep 14, 2022

Please add DOCKER_REGISTRY_URL and DOCKER_REGISTRY_URL_CREDENTIAL_ID in https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/testJobTemplate. Thanks

@LongyuZhang
Add docker registry parameters for jenkins
f2f900c 
- Add docker registry parameters for jenkins

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
@LongyuZhang
Copy link
Contributor Author

The two parameters have been added to testJobTemplate as suggested. Thanks.

llxia
llxia approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LongyuZhang

renfeiw
renfeiw approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renfeiw renfeiw merged commit 9ca37a6 into adoptium:master Sep 14, 2022
LongyuZhang added a commit to LongyuZhang/aqa-tests that referenced this pull request Sep 15, 2022
@LongyuZhang
Add docker registry parameters for jenkins (adoptium#3960)
a440260 
- Add docker registry parameters for jenkins

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
LongyuZhang added a commit to LongyuZhang/aqa-tests that referenced this pull request Sep 15, 2022
@LongyuZhang
Add docker registry parameters for jenkins (adoptium#3960)
3c86992 
- Add docker registry parameters for jenkins

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>

Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renfeiw renfeiw renfeiw approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LongyuZhang @llxia @renfeiw