Add derby tests to the set of External Tests running at Adopt #400
Conversation
|
Related issue: #172 |
Mesbah-Alam
force-pushed
the
addDerbyTests
branch
3 times, most recently
from
aa76c9e
to
8fec0c5
Compare
Mesbah-Alam
force-pushed
the
addDerbyTests
branch
2 times, most recently
from
ab79451
to
9f086b1
Compare
|
We can not use derby from its master branch (trunk) as it requires Java 9 or above to build : We need to checkout from a branch that supports Java 8 and above, which is New personal build submitted with derby 10.14 : https://urv-jenkins.canlab.ibm.com:9095/view/SV_Tests/job/test.personal/106/console |
| <command>docker run --rm -v $(JDK_HOME):/java adoptopenjdk-derby-test:latest ; \ | ||
| $(TEST_STATUS)</command> | ||
| <subsets> | ||
| <subset>SE80</subset> |
There was a problem hiding this comment.
If you drop this subset, then do you not get past the "needs Java9+" error msg?
There was a problem hiding this comment.
Hi @ShelleyLambert , yes we would, but I was under the impression that we want to test Java 8 with the external tests, due to the fact that we have only Java 8 builds for external tests at Adopt (openjdk8_hs* and openjdk8_j9*). Please correct me if I am wrong.
There was a problem hiding this comment.
As per our slack conversation just now, we can add openjdk9* and openjdk10* builds at any time, I just had not gotten to it yet :)
So for now, you could pull material from HEAD for Derby, and run them against Java9 SDKs
There was a problem hiding this comment.
Yes, I am on it. Thanks for clarifying.
There was a problem hiding this comment.
Updated Derby test scripts to pull Derby from HEAD. Tested here: https://urv-jenkins.canlab.ibm.com:9095/view/SV_Tests/job/test.personal/135/console
Mesbah-Alam
force-pushed
the
addDerbyTests
branch
8 times, most recently
from
59d710c
to
126ff05
Compare
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
Add derby tests to the set of External Tests running at Adopt
Signed-off-by: Mesbah Alam Mesbah_Alam@ca.ibm.com