Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jck material versions #4601

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Update jck material versions #4601

merged 1 commit into from
Jun 14, 2023

Conversation

sxa
Copy link
Member

@sxa sxa commented Jun 1, 2023

New versions of the repositories have been created for 8 and 11. This adjusts the test harness to compensate.
Draft while it undergoes testing and iterative updates.

@sxa sxa force-pushed the jck_updates branch 4 times, most recently from b87eceb to 8b8ebc8 Compare June 1, 2023 16:27
@Mesbah-Alam
Copy link
Contributor

Just a note : IBM internal tck repositories for 8 and 11 have to be updated with 8d and 11a materials before this PR can be delivered.

@sxa
Copy link
Member Author

sxa commented Jun 2, 2023

Just a note : IBM internal tck repositories for 8 and 11 have to be updated with 8d and 11a materials before this PR can be delivered.

Is the expection that you'll be able to do that soon? Obviously we'll want this for the next release in July.

@sxa
Copy link
Member Author

sxa commented Jun 2, 2023

@Mesbah-Alam I'm having problems testing this PR because it looks like the harness is no longer starting the agent correctly. Having tried a revert of your PR #4512 it runs correctly. Can you take a look at this please and see if you can fix the missing agent startup?

@Mesbah-Alam
Copy link
Contributor

@sxa , which version of tck are you trying to run? Are you seeing any particular errors?

@smlambert
Copy link
Contributor

Please discuss details in a private DM.

@Mesbah-Alam
Copy link
Contributor

Mesbah-Alam commented Jun 3, 2023

Just an FYI: #4512 is working normally at hyc extended builds (e.g. Test_openjdk8_j9_extended.jck_x86-64_linux/136)-- agents are starting as usual, dependent tests passing, agents then being stopped normally too.

I will pull in the latest version for 8 and 11 and test #4601 at my end.

@Mesbah-Alam
Copy link
Contributor

Mesbah-Alam commented Jun 5, 2023

FYI @sxa , A fix for the issue you encountered with jdwp will be delivered via #4607.

@sxa
Copy link
Member Author

sxa commented Jun 7, 2023

LGTM. On the basis that this PR works as expected I'm going to take this out of draft. Your other PR seems good too.

@sxa sxa marked this pull request as ready for review June 7, 2023 15:16
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@smlambert
Copy link
Contributor

I will tag AQAvit repos prior to merging this PR, in case others who may be using our scripts have a recent tag to fall back to while they update to the latest 8d/11a materials.

@sxa
Copy link
Member Author

sxa commented Jun 9, 2023

I will tag AQAvit repos prior to merging this PR, in case others who may be using our scripts have a recent tag to fall back to while they update to the latest 8d/11a materials.

@Mesbah-Alam is this ok for your internal requirements? I'd like to get this merged today if feasible in order to allow us to be able to run the tests over the weekend.

@sxa sxa self-assigned this Jun 9, 2023
@Mesbah-Alam
Copy link
Contributor

Mesbah-Alam commented Jun 9, 2023

Re #4601 (comment) : Unfortunately, I am occupied with some other work today.

If this is merged now, it will break the internal tck builds. So, please co-ordinate with @llxia and see if the internal 8 and 11 repo's could be updated today by someone else. Other option is, as Shelley suggested, use a tag. Otherwise, please wait till next week and I will update the internal 8 and 11 repos.

@smlambert
Copy link
Contributor

We will plan to merge it next week, and I will post an announcement to the Slack channel to alert any others who may be affected by it.

@Mesbah-Alam
Copy link
Contributor

Mesbah-Alam commented Jun 13, 2023

This PR looks good. Tested with 8d & 11a latest materials:

  • For 8d : Grinder_JCK/1441 (green).
  • For 11a: Grinder_JCK/1442 (green).

Please note, the 'main' branch of the internal repos are yet to be updated with 8d and 11a. I ran my test off of my branch. I will update the 'main' branch once this PR is merged after the tagging is done (Re: #4601 (comment)).

@sxa
Copy link
Member Author

sxa commented Jun 13, 2023

@smlambert Did you get a suitable tag in place? If so it sounds like we can get this in and run a test with all the fixes we have at once against the latest material :-)

@smlambert
Copy link
Contributor

People can use aqa-tests tag: june-2023-pin-jck8c if they can not update to 8d and 11a right away, though the recommendation will be to update their materials asap.

@Mesbah-Alam Mesbah-Alam merged commit e1e2c75 into adoptium:master Jun 14, 2023
1 check passed
@Mesbah-Alam
Copy link
Contributor

Mesbah-Alam commented Jun 14, 2023

Updated Internal tck repos : 8 -> 8d, 11->11a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants