Use JavaTestUtil for all tck #4512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
22 times, most recently
from
b893491
to
49576df
Compare
|
Test with JDK8 OpenJ9:
JDK11 OpenJ9:
JDK17 OpenJ9:
JDK19 OpenJ9:
JDK20 OpenJ9:
|
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
7 times, most recently
from
f98b2a5
to
4d165c6
Compare
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
2 times, most recently
from
70aadf2
to
dcf0e35
Compare
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
from
dcf0e35
to
74e80fb
Compare
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
2 times, most recently
from
de6ccfe
to
9f1f507
Compare
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
2 times, most recently
from
699cd82
to
4696043
Compare
karianna
reviewed
May 17, 2023
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
7 times, most recently
from
139f2b2
to
77d1f02
Compare
karianna
approved these changes
May 18, 2023
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
Mesbah-Alam
force-pushed
the
jtutil-migration
branch
from
77d1f02
to
71248e5
Compare
|
Was it tested at @smlambert 's end before merging? |
|
Yes, I ran tests at the temurin-compliance server, thanks for checking @Mesbah-Alam - I should have added a note! |
|
Perfect, Thanks @smlambert ! |
sxa
added a commit
to sxa/aqa-tests
that referenced
this pull request
Jun 2, 2023
This reverts commit d4e8916.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces JavaTestRunner with JavaTestUtil as the tck automation wrapper.
Impact:
Faster Execution: Absence of JavaTestRunner wrapper means we are using on less JVM instance. The JVM running the actual tests via tck harness jar is not run as a sub-process spawned by the JVM running JavaTeatRunner, but executed directly from playlist. This reduces overall time taken to run JCK builds.
Easy maintenance: Having the ability to specify tck harness parameters directly in the playlist makes each tck playlist command line clearer, easier to maintain and update.
Enhanced debug-ability: Absence of JavaTestRunner wrapper means less redirection hence more debug-ability for failures.
Less overhead in running additional services: Since additional services like rmi registry, rmid, etc, will be launched directly, as opposed to via ProcessBuilder in JavaTestRunner, it should also contribute to overall improved performance of tck builds in Jenkins.
Related to backlog/issues/1013