refine copyArtifacts logic #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llxia
force-pushed
the
test2
branch
2 times, most recently
from
9fc68ad
to
ced6cea
Compare
smlambert
approved these changes
Nov 13, 2023
buildenv/jenkins/JenkinsfileBase
Outdated
| if (env.BUILD_LIST.startsWith('system')) { | ||
| if (env.BUILD_LIST.contains('functional')) { | ||
| timeout(time: 60, unit: 'MINUTES') { | ||
| copyArtifacts fingerprintArtifacts: true, projectName: "test.getDependency", excludes: "json-simple.jar, jtreg*.*", selector: lastSuccessful(), target: 'aqa-tests/TKG/lib' |
There was a problem hiding this comment.
I guess we can exclude jtreg from functional here, because its picked up in compile step, via the build.xml for the ssl-tests and CryptoTest.
There was a problem hiding this comment.
Yes, if the jtreg is not pre-downloaded, it will be downloaded via build.xml during the compilation stage. On second thought, since we are running functional test builds nightly, I think we should include jtreg (in dev and extended level only).
There was a problem hiding this comment.
PR is updated. Grinder - extended.functional
pshipton
approved these changes
Nov 13, 2023
- donwload the 3rd party jars based on BUILD_LIST Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
pshipton
approved these changes
Nov 13, 2023
llxia
added a commit
to llxia/openjdk-tests
that referenced
this pull request
Nov 22, 2023
- donwload the 3rd party jars based on BUILD_LIST Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
llxia
added a commit
to llxia/openjdk-tests
that referenced
this pull request
Nov 22, 2023
- donwload the 3rd party jars based on BUILD_LIST Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
pshipton
pushed a commit
that referenced
this pull request
Nov 22, 2023
- donwload the 3rd party jars based on BUILD_LIST Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will help us to reduce downloads during build execution time. Eventually, we would like to pre-stage the 3rd party jar.
related: #4500