Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable test scripts dry run to github workflow #4942

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jan 5, 2024

Fixes #3917

Using https://github.com/adoptium/aqa-tests/tree/master/scripts/disabled_tests#dry-run-to-see-errors-and-warnings and https://github.com/adoptium/aqa-tests/tree/master/scripts/disabled_tests#dry-run-to-see-info-errors-and-warnings as guides, dry running these scripts will output any errors found in the ProblemList and playlist files.

Example outputs:

exclude_parser.py test:

hkhel@hkhel-mac openjdk-tests % find ./openjdk/excludes -name "ProblemList*" | python3 ./scripts/disabled_tests/exclude_parser.py -v > /dev/null
DEBUG - Taking file list from stdin
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk20.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk21.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk13-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk23.txt...
DEBUG - Processing ./openjdk/excludes/vendors/microsoft/ProblemList_openjdk17.txt...
DEBUG - Processing ./openjdk/excludes/vendors/microsoft/ProblemList_openjdk11.txt...
DEBUG - Processing ./openjdk/excludes/vendors/alibaba/ProblemList_openjdk8.txt...
DEBUG - Processing ./openjdk/excludes/vendors/alibaba/ProblemList_openjdk17.txt...
DEBUG - Processing ./openjdk/excludes/vendors/alibaba/ProblemList_openjdk11.txt...
DEBUG - Processing ./openjdk/excludes/vendors/redhat/ProblemList_openjdk19.txt...
DEBUG - Processing ./openjdk/excludes/vendors/redhat/ProblemList_openjdk18.txt...
DEBUG - Processing ./openjdk/excludes/vendors/redhat/ProblemList_openjdk8.txt...
DEBUG - Processing ./openjdk/excludes/vendors/redhat/ProblemList_openjdk17.txt...
DEBUG - Processing ./openjdk/excludes/vendors/redhat/ProblemList_openjdk11.txt...
DEBUG - Processing ./openjdk/excludes/vendors/azul/ProblemList_openjdk8.txt...
ERROR - ./openjdk/excludes/vendors/azul/ProblemList_openjdk8.txt:74 : Not exactly 3 elements when splitting java/security/Provider/ProviderVersionCheck.java
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk22.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk19.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk16-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk21-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk18.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk11-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk9-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk19-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk23-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk14-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk8.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk17-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk20-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk12-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk18-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk15.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk14.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk16.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk22-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk15-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk17.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk10-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk10-sap.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk13.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk12.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk10.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk8-openj9.txt...
DEBUG - Processing ./openjdk/excludes/ProblemList_openjdk11.txt...
DEBUG - Outputting to stdout

Error in openjdk/excludes/vendors/azul/ProblemList_openjdk8.txt:74:

# jdk_security1
java/security/Provider/ProviderVersionCheck.java

Just the test, no issue link or platform so it shows up as an error

playlist_parser.py test:

hkhel@hkhel-mac openjdk-tests % find . -name "playlist.xml" | python3 ./scripts/disabled_tests/playlist_parser.py -v > /dev/null
ERROR - Uncaught exception while processing './jck/runtime.lang/playlist.xml' : Opening and ending tag mismatch: test line 370 and playlist, line 421, column 12 (playlist.xml, line 421)
INFO - Processed './jck/devtools.jaxws/playlist.xml' : n_disables=0
INFO - Processed './jck/devtools.schema2java/playlist.xml' : n_disables=0
INFO - Processed './jck/compiler.api/playlist.xml' : n_disables=13
INFO - Processed './jck/devtools.schema_bind/playlist.xml' : n_disables=0
INFO - Processed './jck/devtools.xml_schema/playlist.xml' : n_disables=0
INFO - Processed './jck/devtools.java2schema/playlist.xml' : n_disables=0
INFO - Processed './jck/compiler.lang/playlist.xml' : n_disables=123
INFO - Processed './jck/runtime.api/playlist.xml' : n_disables=28
INFO - Processed './jck/runtime.xml_schema/playlist.xml' : n_disables=4
INFO - Processed './jck/runtime.vm/playlist.xml' : n_disables=6
INFO - Processed './openjdk/playlist.xml' : n_disables=56
INFO - Processed './system/mathLoadTest/playlist.xml' : n_disables=2
INFO - Processed './system/daaLoadTest/playlist.xml' : n_disables=0
INFO - Processed './system/otherLoadTest/playlist.xml' : n_disables=7
INFO - Processed './system/security/playlist.xml' : n_disables=4
INFO - Processed './system/jcstress/playlist.xml' : n_disables=6
INFO - Processed './system/sharedClasses/playlist.xml' : n_disables=0
INFO - Processed './system/modularity/playlist.xml' : n_disables=3
INFO - Processed './system/jlm/playlist.xml' : n_disables=6
INFO - Processed './system/lambdaLoadTest/playlist.xml' : n_disables=4
...

(Placed a deliberate error in jck/runtime.lang/playlist.xml)

@Haroon-Khel Haroon-Khel changed the title dry run both scripts in linter Add disable test scripts dry run to github workflow Jan 5, 2024
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Haroon-Khel !

I will merge this, as we are about to exercise it as part of our pre-release triage ahead of Jan CPU.

@smlambert smlambert merged commit 3becd04 into adoptium:master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorporate the disabled_tests scripts into PR check
3 participants