Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded new written security infra tests #4955

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

sophia-guo
Copy link
Contributor

Related #4808

@pshipton
Copy link
Contributor

Pls add the excludes to the J9 exclude lists as well.

@smlambert
Copy link
Contributor

smlambert commented Jan 10, 2024

To ease this change, could consider just excluding the jdk_security_infra target since these 44 failing testcases are the bulk of it (it has 45 testcases, only 1 passing).

@Haroon-Khel - FYI, this is the first exercising of the disabled_tests linter, see that it has an error:

Run find . -name "playlist.xml" | python3 ./scripts/disabled_tests/playlist_parser.py -v > /dev/null
Traceback (most recent call last):
  File "/home/runner/work/aqa-tests/aqa-tests/./scripts/disabled_tests/playlist_parser.py", line 9, in <module>
    import lxml.etree
ModuleNotFoundError: No module named 'lxml'
Error: Process completed with exit code 1.
Screenshot 2024-01-10 at 1 57 08 PM

SL/edit, raising an issue to fix linter.

@pshipton
Copy link
Contributor

Pls add the excludes to the J9 exclude lists as well.

There is one complication. The tests should be excluded for all OpenJ9 platforms except for z/OS.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Contributor Author

Disabled by playlist.xml for all platforms. Deleted disabled tests in Problemlist.txt as tests have been rewritten with new framework those tests are not available anymore.

Those tests failed for all platforms, any reason we need to keep them for z/OS @pshipton ?

@pshipton
Copy link
Contributor

z/OS uses the OpenJDK cacerts, so the tests will pass, and not the ones provided by the Adoptium pipelines.

Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
@sophia-guo
Copy link
Contributor Author

@pshipton Thanks, updated.

@pshipton
Copy link
Contributor

The linter failed so I won't merge this now.

@sophia-guo
Copy link
Contributor Author

Linter issue is related with refer to . see #4955 (comment).

@sophia-guo sophia-guo merged commit a45c03c into adoptium:master Jan 11, 2024
1 of 2 checks passed
@sophia-guo sophia-guo self-assigned this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants