Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose moving Test lists and Enable Test bool to a config file #93

Closed
AdamBrousseau opened this issue Mar 12, 2021 · 3 comments · Fixed by #102
Closed

Propose moving Test lists and Enable Test bool to a config file #93

AdamBrousseau opened this issue Mar 12, 2021 · 3 comments · Fixed by #102

Comments

@AdamBrousseau
Copy link
Contributor

As a third party user, I will tend to have a different test list than what is in build_base_file.groovy. I will also not necessarily want to follow changes made to ENABLE_TESTS such as #92. I am proposing we move these values into a configuration file so that users can point to their own config file.

@M-Davies M-Davies added this to To do in ci-jenkins-pipelines via automation Mar 12, 2021
@M-Davies
Copy link
Contributor

Ref:
https://github.com/AdoptOpenJDK/ci-jenkins-pipelines/blob/bb2ada1e00694a18a00060d8ee37fb36b7f38a75/pipelines/build/common/build_base_file.groovy#L219-L223
and the test field of #data fields:

Name Required? Type
Description
test String
OR
Map<String, List>
Tests to run against the binary after the build has completed. A default tag indicates that you want to run whatever the default test nightly/release list is.

Otherwise, you can specify your own list for that paticular platform (not variant)

There shouldn't be a need to specify a new config parameter if we already have one that appears to do what you are describing regarding specifying your own tests.

I will also not necessarily want to follow changes made to ENABLE_TESTS

That however is something that should be moved into a config file. I will look into this

@M-Davies M-Davies added this to the March 2021 milestone Mar 17, 2021
@M-Davies M-Davies moved this from To do to In progress in ci-jenkins-pipelines Mar 17, 2021
@M-Davies M-Davies self-assigned this Mar 17, 2021
@AdamBrousseau
Copy link
Contributor Author

There shouldn't be a need to specify a new config parameter if we already have one that appears to do what you are describing regarding specifying your own tests.

This feature is useful if you have an odd spec that does not follow the default. However for my use, all my specs run the same testing but that list does not match the Adopt default. I would therefore need to paste my list into every spec which is inconvenient. Moving that default list into defaults.json for example, would allow me to change it to my liking for all specs at once. Both for the Nightly and Weekly lists.

ci-jenkins-pipelines automation moved this from In progress to Done Mar 18, 2021
@AdamBrousseau
Copy link
Contributor Author

Thanks, Morgan!

AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this issue Sep 28, 2022
Enable FIPS testing for plinux for JDK8, 11 and 17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants